Skip to content

BAU: guardrail to ensure pentester email parity#2199

Open
whi-tw wants to merge 1 commit into
mainfrom
whi-tw/guardrail_pentester_email_addresses
Open

BAU: guardrail to ensure pentester email parity#2199
whi-tw wants to merge 1 commit into
mainfrom
whi-tw/guardrail_pentester_email_addresses

Conversation

@whi-tw

@whi-tw whi-tw commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

As we maintail the pentester email addresses in two places, we need to
nsure they are kept in sync. This guardrail checks that the email
addresses match in both locations and that they are only set in staging.

This is similar to the guardrail we have for the CIDR blocks.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

As we maintail the pentester email addresses in two places, we need to
nsure they are kept in sync. This guardrail checks that the email
addresses match in both locations and that they are only set in staging.

This is similar to the guardrail we have for the CIDR blocks.
@whi-tw whi-tw force-pushed the whi-tw/guardrail_pentester_email_addresses branch from bee9abe to c4493ab Compare July 10, 2026 14:25
@whi-tw whi-tw requested a review from theseanything July 10, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants