Skip to content

Remove GOV_UK_APP_DOMAIN from Dockerfile#2952

Open
thomasiles wants to merge 1 commit into
mainfrom
remove-govuk-app-domain
Open

Remove GOV_UK_APP_DOMAIN from Dockerfile#2952
thomasiles wants to merge 1 commit into
mainfrom
remove-govuk-app-domain

Conversation

@thomasiles

Copy link
Copy Markdown
Contributor

We used to include the GDS sso gem, which also depends on plek. This meant we had to set the GOV_UK_APP_DOMAIN env var to a dummy value in order to run the application in production.

We no longer depend on the GDS sso gem or plek, so we can remove this value from the Dockerfile.

See:
https://docs.publishing.service.gov.uk/repos/plek.html

What problem does this pull request solve?

Trello card:

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

We used to include the GDS sso gem, which also depends on plek. This
meant we had to set the GOV_UK_APP_DOMAIN env var to a dummy value in
order to run the application in production.

We no longer depend on the GDS sso gem or plek, so we can remove this
value from the Dockerfile.

See:
https://docs.publishing.service.gov.uk/repos/plek.html
@github-actions

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2952.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@thomasiles
thomasiles marked this pull request as ready for review July 20, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant