Show result counts on the users list page#2924
Merged
Merged
Conversation
The users list is paginated but does not say how many users there are in total, so administrators cannot see how many users match the filters they have applied without paging through the whole list. Add a count above the table matching the one on the organisations list: "Showing x to y of n users" when the results span multiple pages, or just the total number of users when they fit on one page.
theseanything
force-pushed
the
users-list-showing-count
branch
from
cd987d0 to
189e3bd
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2924.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a count above the table matching the one on the organisations list: "Showing x to y of n users" when the results span multiple pages, or just the total number of users when they fit on one page. (Same as organisation page)
Helpful to see total number of users, and number of users when filtered.