Add smoke test form to database seed#2892
Open
lfdebrux wants to merge 2 commits into
Open
Conversation
By default a question should be not optional and not repeatable. We shouldn't need to specify `is_optional: false` every time we create a `Page`. This commit updates the default in the database column, and updates our database seed to be less verbose.
In each environment in AWS we have a smoke test form which is used by the tests in the forms-e2e-tests repo. This commit adds a form with the same setup as what is in the production environment to our database seed. We also add a smoke tests group to the database seed, again matching what we have in production. Note that the forms-e2e-tests repo can't use the "All question types form" for the smoke tests, as it currently doesn't know how to answer all question types.
lfdebrux
force-pushed
the
ldeb-add-smoke-test-form
branch
from
563c77a to
85f7266
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2892.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
In each environment in AWS we have a smoke test form which is used by the tests in the forms-e2e-tests repo. This commit adds a form with the same setup as what is in the production environment to our database seed. We also add a smoke tests group to the database seed, again matching what we have in production.
Note that the forms-e2e-tests repo can't use the "All question types form" for the smoke tests, as it currently doesn't know how to answer all question types.
Things to consider when reviewing