Skip to content

Add exit pages multiple branches#2886

Draft
thomasiles wants to merge 5 commits into
mainfrom
add-exit-pages-multiple-branches
Draft

Add exit pages multiple branches#2886
thomasiles wants to merge 5 commits into
mainfrom
add-exit-pages-multiple-branches

Conversation

@thomasiles

Copy link
Copy Markdown
Contributor

WIP: Use ExitPage model when available in Condition model

Trello card: https://trello.com/c/gZGRBU8Y/3172-change-add-edit-delete-exit-page-to-work-with-new-style-exit-page-model

First parts of using ExitPage model instead of condition attributes to model exit pages.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@SamJamCul SamJamCul force-pushed the add-exit-pages-multiple-branches branch from 9357172 to 0cb6a32 Compare July 6, 2026 14:32
I think this ensures the arg is passed on to the setters.
Try using accepts_nested_attributes_for to ensure exit_page is updated
when the condition is updated.
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2886.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant