Skip to content

fix(docker-compsose): add host.docker.internal as extra hosts - #1

Open
ferferga wants to merge 1 commit into
governify:mainfrom
us-ferferga:main
Open

ferferga wants to merge 1 commit into
governify:mainfrom
us-ferferga:main

Conversation

@ferferga

@ferferga ferferga commented Jun 5, 2024

Copy link
Copy Markdown

host.docker.internal only works fine for inter-container communication for MacOS systems, at least according to the documentation we have.

With this approach, Docker will handle all the OS-specific behaviour for us.

This is a workaround that should eventually be removed

host.docker.internal only works fine for inter-container communication for MacOS systems, at least
according to the documentation we have.

With this approach, Docker will handle all the OS-specific behaviour for us.

This is a workaround that should eventually be removed

Signed-off-by: GitHub <noreply@github.com>

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this one intact since the deployment we've been working on for the past month it's based on the docker-compose-local file, hence this one is untested and only the safest change (the extra_hosts addition) has been performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant