fix: support cost attribution env based query labeling #95
+29
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deryrahman
reviewed
Dec 9, 2025
mc2mc/internal/query/builder.go
Outdated
|
|
||
| // constructMergeQueries constructs merge queries with headers and variables | ||
| func (b *Builder) constructMergeQuery(hrs, vars, queries []string) string { | ||
| func (b *Builder) constructMergeQuery(hrs, vars, queries []string, costAttributionTeam string) string { |
Member
There was a problem hiding this comment.
no need to pass costAttributionTeam argument here, we can use var in builder object itself
Member
Author
There was a problem hiding this comment.
sure, nice idea, i have done the changes
deryrahman
approved these changes
Jan 5, 2026
deryrahman
reviewed
Jan 5, 2026
Member
deryrahman
left a comment
deryrahman
left a comment
There was a problem hiding this comment.
LGTM, just create one or more test case in builder_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.