Repository navigation
fix(pi-permission-system): approve bash chain units separately - #1097
Open
mikemikimike wants to merge 1 commit into
Open
mikemikimike wants to merge 1 commit into
mikemikimike wants to merge 1 commit into
Conversation
|
@gotgenes I think this would be a good addition, I hit this papercut all the time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1095
#1095
Ask separately for each unresolved command in a bash chain so each session approval describes what it grants. Keep deny checks ahead of prompts and avoid partial session grants when parsing recovers incomplete syntax. Suggest a directory-specific pattern for
cd.Validation:
pnpm run checkpnpm run lintpnpm run testand the permission-system suite have existing Windows failures; the permission-system failure list matches the unmodified base.