feat: add StrictQueryParamSep for net/url-aligned query matching#801
Open
leno23 wants to merge 1 commit into
Open
feat: add StrictQueryParamSep for net/url-aligned query matching#801leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Introduce Router.StrictQueryParamSep to optionally split Queries route parameters on '&' only, matching net/url since Go 1.17. The default false preserves legacy ';' splitting for backward compatibility. Fixes gorilla#781 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Router.StrictQueryParamSep(true)for Queries route matching&only, aligning withnet/urlsince Go 1.17falseto preserve legacy splitting on both∧Fixes #781
Problem
Queriesmatching treats;as a parameter separator while modernnet/urldoes not. Mixed use (e.g. auth checks viar.URL.Query()and routing viamux.Vars) can disagree on parameter values, enabling authorization bypasses.Approach
This follows option 2 from the issue discussion: an opt-in router flag with backward-compatible defaults, avoiding an immediate breaking change for clients that rely on semicolon-separated query strings.
Test plan
go test -run 'Test_findFirstQueryKey|TestStrictQueryParamSep' -vgo test ./... -count=1