Skip to content

feat: change plugins to be at top-level #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rice-riley merged 1 commit into from
Jan 16, 2026
Merged

feat: change plugins to be at top-level #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/internal/core/ @riceriley59

# Plugin implementations
/internal/plugins/ @riceriley59
/plugins/ @riceriley59

# CLI
/internal/cli/ @riceriley59
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ When reporting issues, please include:

If you're adding a new language plugin:

1. Create a new package under `internal/plugins/<language>/`
1. Create a new package under `plugins/<language>/`
2. Implement the `core.Plugin` interface
3. Register the plugin in `init()` using `factory.Register()`
4. Add comprehensive tests
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ include deps.mk


GIT_SHA := $(shell git rev-parse --short HEAD)
GIT_TAG_LAST := $(shell git tag --list 'operator*' --sort=-v:refname | head -n 1 | cut -d/ -f2)
GIT_TAG_LAST := $(shell git tag --list 'v*' --sort=-v:refname | head -n 1)

## GO Flags
GO_LDFLAGS := -ldflags "-X github.com/riceriley59/goanywhere/internal/version.GIT_SHA=$(GIT_SHA) \
Expand Down
4 changes: 2 additions & 2 deletions internal/cli/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import (
"github.com/riceriley59/goanywhere/internal/core/factory"

// Register plugins
_ "github.com/riceriley59/goanywhere/internal/plugins/cgo"
_ "github.com/riceriley59/goanywhere/internal/plugins/python"
_ "github.com/riceriley59/goanywhere/plugins/cgo"
_ "github.com/riceriley59/goanywhere/plugins/python"
)

type generateOptions struct {
Expand Down
0 internal/plugins/cgo/mapper.go → plugins/cgo/mapper.go
View file
Open in desktop
File renamed without changes.
0 internal/plugins/cgo/mapper_test.go → plugins/cgo/mapper_test.go
View file
Open in desktop
File renamed without changes.
0 internal/plugins/cgo/plugin.go → plugins/cgo/plugin.go
View file
Open in desktop
File renamed without changes.
0 internal/plugins/python/mapper.go → plugins/python/mapper.go
View file
Open in desktop
File renamed without changes.
0 internal/plugins/python/mapper_test.go → plugins/python/mapper_test.go
View file
Open in desktop
File renamed without changes.
0 internal/plugins/python/plugin.go → plugins/python/plugin.go
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions tests/integration/bindings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import (
. "github.com/onsi/gomega"

"github.com/riceriley59/goanywhere/internal/core"
"github.com/riceriley59/goanywhere/internal/plugins/cgo"
"github.com/riceriley59/goanywhere/internal/plugins/python"
"github.com/riceriley59/goanywhere/plugins/cgo"
"github.com/riceriley59/goanywhere/plugins/python"
)

func TestIntegration(t *testing.T) {
Expand Down