Skip to content

fix: add --locked flag to cargo install cargo-llvm-cov in coverage.sh #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaolai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add --locked flag to cargo install cargo-llvm-cov in coverage.sh #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-pin-cargo-llvm-cov.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@googleworkspace/cli": patch
---

Add --locked flag to cargo install cargo-llvm-cov in coverage.sh for reproducible installs
2 changes: 1 addition & 1 deletion scripts/coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ set -euo pipefail
# Check if cargo-llvm-cov is installed
if ! cargo llvm-cov --version &> /dev/null; then
echo "cargo-llvm-cov is not installed. Installing..."
cargo install cargo-llvm-cov
cargo install --locked cargo-llvm-cov
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

While the --locked flag ensures that transitive dependencies are pinned to the versions specified in the tool's Cargo.lock, it does not pin the version of cargo-llvm-cov itself. For truly reproducible and secure installs, the tool version should also be pinned (e.g., cargo install --locked --version 0.6.11 cargo-llvm-cov). Without this, the script will always install the latest version available on crates.io, which could introduce breaking changes or security vulnerabilities, partially defeating the purpose of the reproducibility and security goals stated in this pull request.

fi

# Run coverage and generate HTML report
Expand Down
Loading