Skip to content

fix: replace nonexistent Forms API list method with Drive files list#758

Open
xiaolai wants to merge 1 commit intogoogleworkspace:mainfrom
xiaolai:fix/nlpm-forms-list-nonexistent-method
Open

fix: replace nonexistent Forms API list method with Drive files list#758
xiaolai wants to merge 1 commit intogoogleworkspace:mainfrom
xiaolai:fix/nlpm-forms-list-nonexistent-method

Conversation

@xiaolai
Copy link
Copy Markdown

@xiaolai xiaolai commented Apr 25, 2026

Automated audit: This PR was generated by NLPM, a natural language programming linter, running via claude-code-action. Please evaluate the diff on its merits.

The recipe-collect-form-responses skill references gws forms forms list in step 1. The Google Forms API v1 does not have a list method on the forms resource — it only supports get, create, patch, batchUpdate, and responses.list. Calling this command will always return an API error, making it impossible for users to discover their form IDs through the recipe.

The fix replaces step 1 with a Drive API files list query filtered to application/vnd.google-apps.form MIME type, which correctly enumerates all Google Forms in the user's Drive. Since this now depends on the Drive API, gws-drive is added as a prerequisite skill in both the YAML frontmatter skills: list and the PREREQUISITE line in the body.

The Google Forms API v1 does not expose a list method on the forms
resource. The recipe step `gws forms forms list` will always fail.
Replace it with a Drive files list query filtered by the Forms MIME
type, and add gws-drive as a prerequisite skill in both the frontmatter
and the PREREQUISITE line.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 25, 2026

🦋 Changeset detected

Latest commit: b645741

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a functional error in the 'recipe-collect-form-responses' skill where an invalid API call was being used to list forms. By switching to the Drive API, the recipe now correctly enables users to discover their form IDs, ensuring the subsequent steps in the workflow can execute successfully.

Highlights

  • API Correction: Replaced the non-existent 'gws forms forms list' command with a valid 'gws drive files list' query to correctly identify Google Forms.
  • Dependency Update: Added 'gws-drive' as a required skill in the recipe metadata and documentation to support the new listing method.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 25, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the recipe-collect-form-responses skill to use the Google Drive API for listing forms, as the Forms API lacks a list method. The changes include updating the skill metadata, prerequisites, and the command-line instructions in the documentation. A review comment correctly identified that the Drive API query syntax requires single quotes for string literals and suggested filtering out trashed files to avoid potential errors and improve the clarity of the results.

## Steps

1. List forms: `gws forms forms list` (if you don't have the form ID)
1. Find your form ID: `gws drive files list --params '{"q": "mimeType = \"application/vnd.google-apps.form\""}' --format table`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The Google Drive API query syntax requires single quotes for string literals (e.g., mimeType = '...'). Using escaped double quotes (\") inside the query string will likely cause the API to return a 400 "Invalid query" error. Additionally, it is recommended to include trashed = false in the query to avoid listing deleted forms, which can be confusing for users.

Suggested change
1. Find your form ID: `gws drive files list --params '{"q": "mimeType = \"application/vnd.google-apps.form\""}' --format table`
1. Find your form ID: gws drive files list --params "{\"q\": \"mimeType = 'application/vnd.google-apps.form' and trashed = false\"}" --format table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants