prettify+eslint codebase#1387
Open
chrisjshull wants to merge 23 commits intomainfrom
Open
Conversation
…rettier ignore lines
…rettier ignore lines
# Conflicts: # samples/routes-get-directions/index.ts
…row the returned type to non-nullable
make newlines preserve in TS->JS make build-all fail on any failures simplify cross-platform sed calls other misc prettifying start enforcing no google.maps usage in runtime
…nto prettier-pass3 # Conflicts: # package-lock.json # package.json
|
Here is the summary of changes. You are about to add 14 region tags.
You are about to delete 15 region tags.
This comment is generated by snippet-bot.
|
do simple tests first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includes many manual edits, including lots of typings fixes, and removal of typecasts that aren't needed anymore
also set things up to better enforce normalized code
also will preserve newlines in final JS code
and got rid of most google.maps.* calls