🔧 infrastructure: parameterize envoyExtAuthzHttp extensionProviders via Helm values#828
Draft
Tobias-Pe wants to merge 6 commits into
Draft
🔧 infrastructure: parameterize envoyExtAuthzHttp extensionProviders via Helm values#828Tobias-Pe wants to merge 6 commits into
Tobias-Pe wants to merge 6 commits into
Conversation
…ia Helm values Parameterize Istio extensionProviders in base-cloud chart via values-cloud.yaml to decouple commercial auth configuration from open-source release manifests. #### Why Parameterize Istio extensionProviders via Helm values to achieve clean OSS/commercial separation and eliminate fragile post-install ConfigMap patching. #### The code changes include: - Support -f / --values CLI flags in deploy.sh - Add additionalExtensionProviders Go template snippet to ConfigMap/istio in update-istio.sh and istio-generated.yaml - Set default istio.additionalExtensionProviders: [] in values-cloud.yaml TESTED=UNITTESTS (bazel test //src/app_charts/base/... passed) RELNOTES=NONE Created using jj-spr
Contributor
Author
|
This PR is a standalone change. |
Created using jj-spr
Created using jj-spr
Created using jj-spr
Created using jj-spr
ensonic
reviewed
Jul 22, 2026
| fi | ||
| if ! command -v "${YQ}" &>/dev/null && [[ -x "/usr/local/google/home/tpeslalz/go/bin/yq" ]]; then | ||
| YQ="/usr/local/google/home/tpeslalz/go/bin/yq" | ||
| fi |
ensonic
reviewed
Jul 22, 2026
| --set "use_tv_verbose=${CRC_USE_TV_VERBOSE}" | ||
| ) | ||
|
|
||
| shift 6 |
Contributor
There was a problem hiding this comment.
I'd move the "shift 6" up to line 258.
Created using jj-spr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameterize Istio extensionProviders in base-cloud chart via values-cloud.yaml to decouple commercial auth configuration from open-source release manifests.
Why
Parameterize Istio extensionProviders via Helm values to achieve clean OSS customization separation and eliminate fragile post-install ConfigMap patching.
The code changes include:
TESTED=UNITTESTS (bazel test //src/app_charts/base/... passed)
RELNOTES=NONE