fix(adk): wrap tool execution errors into error output#596
Open
Deeven-Seru wants to merge 1 commit intogoogleapis:mainfrom
Open
fix(adk): wrap tool execution errors into error output#596Deeven-Seru wants to merge 1 commit intogoogleapis:mainfrom
Deeven-Seru wants to merge 1 commit intogoogleapis:mainfrom
Conversation
dishaprakash
added
the
priority: p1
Contributor
|
@Deeven-Seru Thanks for the PR! Can you resolve the conflicts? |
Contributor
|
/gcbrun |
Contributor
Author
|
@anubhav756 could u please take a look & re initiate the checks ..thanks:) |
Deeven-Seru
force-pushed
the
fix/toolbox-adk-wrap-tool-errors
branch
2 times, most recently
from
eac456e to
b80c202
Compare
anubhav756
force-pushed
the
fix/toolbox-adk-wrap-tool-errors
branch
from
b80c202 to
3bf4b1c
Compare
Contributor
|
/gcbrun |
Contributor
Hi @Deeven-Seru! Couldn't get to it earlier. Retriggered! |
Contributor
Author
|
Fixes made for ADK check failures:
|
Contributor
|
/gcbrun |
anubhav756
requested changes
Apr 15, 2026
Contributor
anubhav756
left a comment
anubhav756
left a comment
There was a problem hiding this comment.
Could you also take a look at the failures? Thanks!
Deeven-Seru
force-pushed
the
fix/toolbox-adk-wrap-tool-errors
branch
2 times, most recently
from
af3a58c to
d9ef159
Compare
Contributor
|
/gcbrun |
Deeven-Seru
force-pushed
the
fix/toolbox-adk-wrap-tool-errors
branch
from
d9ef159 to
6d609c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary- catch Toolbox tool execution exceptions and return an error response so ADK after-tool callbacks can handle recoverable failures- log tool execution failures for visibility- add a unit test covering exception-to-error wrapping
fixes googleapis/mcp-toolbox#2728