impl(pubsub): update last extension for successful extend#5530
Draft
PhongChuong wants to merge 1 commit intogoogleapis:mainfrom
Draft
impl(pubsub): update last extension for successful extend#5530PhongChuong wants to merge 1 commit intogoogleapis:mainfrom
PhongChuong wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5530 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 218 218
Lines 49498 49571 +73
=======================================
+ Hits 48390 48462 +72
- Misses 1108 1109 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lease state propagate extension results back to LeaseLoop using by the LeaseEvent ExtendCompleted and ExtendCompletedEO. The result are used to update the last extension value in the lease state. We also discard previously extensions that are not complete by the next lease extension interval.
An alternative solution was to use channels (either a new channel or the existing confirmed channel) but it would not allow us to easily discard old extension results from previous lease extension intervals.
Fixes: #5048