X25519 and Ed25519 ffi and js implementations#232
Open
tzaid wants to merge 2 commits intogoogle:masterfrom
Open
X25519 and Ed25519 ffi and js implementations#232tzaid wants to merge 2 commits intogoogle:masterfrom
tzaid wants to merge 2 commits intogoogle:masterfrom
Conversation
Member
|
Thanks, I suspect we might still want to polish what we have an get a new version released, before we expand the scope. Also what is the browser support status, have all agreed implement these yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't feel like waiting for v1.1 to get these so I implemented them. The PR includes interfaces and implementations for ffi, js and stubs for both X25519 and Ed25519. For Ed25519, only signBytes and verifyBytes is supported but happy to provide a stream wrapper if required.