create clear boundaries for global step, mini batch and micro batch#1096
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
create clear boundaries for global step, mini batch and micro batch#1096copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
sizhit2,
tianshub and
wang2yn84
as code owners
In order to add metric instrumentations, we need to have clearer boundaries of when the global step is starting, when the mini batch is starting, etc. refactoring the code to reflect that.
The added comments will be replaced with metric instrumentations, e.g., `with self.rl_cluster.perf.span_group("global_step"):` in follow up cl.
PiperOrigin-RevId: 869849068
copybara-service
bot
force-pushed
the
test_869849068
branch
from
1a2fbe2 to
d7f57e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create clear boundaries for global step, mini batch and micro batch
In order to add metric instrumentations, we need to have clearer boundaries of when the global step is starting, when the mini batch is starting, etc. refactoring the code to reflect that.
The added comments will be replaced with metric instrumentations, e.g.,
with self.rl_cluster.perf.span_group("global_step"):in follow up cl.