Repository navigation
Reset PRNG key placement in distributed_array tutorial - #109
Merged
Merged
Conversation
jax_jit stores its output key in env.prng_key, committing it to the last call's devices, so switching between sharded and single-device inputs fails with "incompatible devices". Reset the key to an uncommitted copy at each switch, and note the limitation in interop.
qihqi
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jax_jitstores its output key inenv.prng_key, committing it to the last call's devices, so switching between sharded and single-device inputs fails with "incompatible devices". Reset the key to an uncommitted copy at each switch, and note the limitation in interop.The error from https://github.com/google/torchax/actions/workflows/static.yml recently, is that the PRNG
env.prng_keyis now committed after first use. If the first use is computation on sharded device, and then the second use is on some single device (or vise versa), the committed PRNG cause runtime error.See also: #95 for more background where this behavior was introduced.
I have try some solution in https://github.com/google/torchax/tree/prng-split-before-call, but I think that takes some time to get a mature and solid solution. Let's treat current implementation/design as a limitation and go back later.