Skip to content

Fix the heading level of the latest post performance tile titles - #14201

Merged
zutigrm merged 2 commits into
developfrom
bug/14112-latest-post-tile-headings
Nov 18, 2026
Merged

zutigrm merged 2 commits into
developfrom
bug/14112-latest-post-tile-headings

Conversation

@shervElmi

Copy link
Copy Markdown
Collaborator

Summary

Related issue(s):

Relevant technical choices

  • The doc line of titleAs in TileShell.tsx now reads "Heading element of the title, h3 by default.", the words TableTile.tsx gives the same prop, as asked on the issue.
  • The doc lines of title in TileShell.tsx and of titleAs in TableTile.tsx stay as they are, because each says what its prop is, with no one use named.
  • The tile titles keep their look at every width, because their class styles set the colour, font size and margin that WordPress's h3 and h4 styles set differently.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

The three tiles sit under the level 3 heading "Latest post performance since published". A screen reader now lists their titles inside that section, not beside it. A new test checks the level of each heading in the section.

Their look stays the same. Their class styles set the colour, the font size and the margin, which WordPress sets differently for an `h3` and an `h4`.
It named one use, a tile under an `h3` heading. It now says what the prop is, in the words `TableTile` gives the same prop.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the heading levels of the tiles within the LatestPostPerformance component by setting the titleAs prop of LatestPostTile to "h4" so that they render as headings one level below the section's h3 heading. It also updates the JSDoc documentation for TileShellProps and adds a test case in LatestPostPerformance.test.tsx to verify the correct heading levels are rendered. There are no review comments, and I have no feedback to provide.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

🤖 This comment is automatically updated by CI workflows. Each section is managed independently.

📚 Storybook for 4a7b10f:

  • Storybook has been deleted.

📦 Build files for 4a7b10f:

  • Build files have been deleted.

🖼️ VRT report for 4a7b10f:

  • Reports have been deleted.

🎭 Playwright reports for 4a7b10f:

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 3.55 MB

ℹ️ View Unchanged
Filename Size Change
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 47.1 kB 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 7.25 kB 0 B
dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 6.46 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 7.26 kB 0 B
dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 6.46 kB 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
dist/assets/blocks/sign-in-with-google/editor-styles.js 0 B 0 B 🆕
dist/assets/blocks/sign-in-with-google/index.js 18.5 kB 0 B
dist/assets/css/googlesitekit-admin-css-********************.min.css 78.8 kB 0 B
dist/assets/css/googlesitekit-adminbar-css-********************.min.css 12.7 kB 0 B
dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 851 B 0 B
dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 9.09 kB 0 B
dist/assets/js/492-********************.js 970 B 0 B
dist/assets/js/959-********************.js 3 kB 0 B
dist/assets/js/1020-********************.js 1.03 kB 0 B
dist/assets/js/1212-********************.js 2.26 kB 0 B
dist/assets/js/1315-********************.js 3.08 kB 0 B
dist/assets/js/3022-********************.js 2.41 kB 0 B
dist/assets/js/3741-********************.js 3.84 kB 0 B
dist/assets/js/6174-********************.js 3.67 kB 0 B
dist/assets/js/7603-********************.js 61.5 kB 0 B
dist/assets/js/7792-********************.js 110 kB 0 B
dist/assets/js/9397-********************.js 477 kB 0 B
dist/assets/js/analytics-advanced-tracking-********************.js 428 B 0 B
dist/assets/js/googlesitekit-activation-********************.js 31.8 kB 0 B
dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 71.4 kB 0 B
dist/assets/js/googlesitekit-admin-pointers-********************.js 6.88 kB 0 B
dist/assets/js/googlesitekit-adminbar-********************.js 38.8 kB 0 B
dist/assets/js/googlesitekit-api-********************.js 9.91 kB 0 B
dist/assets/js/googlesitekit-block-tracking-********************.js 6.88 kB 0 B
dist/assets/js/googlesitekit-components-********************.js 7.02 kB 0 B
dist/assets/js/googlesitekit-consent-mode-********************.js 25.5 kB 0 B
dist/assets/js/googlesitekit-data-********************.js 1.84 kB 0 B
dist/assets/js/googlesitekit-datastore-forms-********************.js 8.6 kB 0 B
dist/assets/js/googlesitekit-datastore-location-********************.js 1.6 kB 0 B
dist/assets/js/googlesitekit-datastore-pdf-********************.js 1.23 kB 0 B
dist/assets/js/googlesitekit-datastore-site-********************.js 21.7 kB 0 B
dist/assets/js/googlesitekit-datastore-ui-********************.js 8.76 kB 0 B
dist/assets/js/googlesitekit-datastore-user-********************.js 26.9 kB 0 B
dist/assets/js/googlesitekit-entity-dashboard-********************.js 97.4 kB 0 B
dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 1.27 kB 0 B
dist/assets/js/googlesitekit-events-provider-content-events-********************.js 3.16 kB 0 B
dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 651 B 0 B
dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 1.24 kB 0 B
dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 1.26 kB 0 B
dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 1.28 kB 0 B
dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 1.35 kB 0 B
dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 895 B 0 B
dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 1.3 kB 0 B
dist/assets/js/googlesitekit-feature-discovery-********************.js 26.7 kB 0 B
dist/assets/js/googlesitekit-features-********************.js 91 kB 0 B
dist/assets/js/googlesitekit-features-badge-********************.js 835 B 0 B
dist/assets/js/googlesitekit-i18n-********************.js 4.43 kB 0 B
dist/assets/js/googlesitekit-intents-********************.js 9.33 kB 0 B
dist/assets/js/googlesitekit-key-metrics-setup-********************.js 66.5 kB 0 B
dist/assets/js/googlesitekit-main-dashboard-********************.js 230 kB 0 B
dist/assets/js/googlesitekit-metric-selection-********************.js 68.9 kB 0 B
dist/assets/js/googlesitekit-modules-********************.js 30.9 kB 0 B
dist/assets/js/googlesitekit-modules-ads-********************.js 62.1 kB 0 B
dist/assets/js/googlesitekit-modules-adsense-********************.js 158 kB 0 B
dist/assets/js/googlesitekit-modules-analytics-4-********************.js 319 kB +2 B (0%)
dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 32.5 kB 0 B
dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 144 kB 0 B
dist/assets/js/googlesitekit-modules-search-console-********************.js 79.5 kB 0 B
dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 41.2 kB 0 B
dist/assets/js/googlesitekit-modules-tagmanager-********************.js 35 kB 0 B
dist/assets/js/googlesitekit-notifications-********************.js 98.8 kB 0 B
dist/assets/js/googlesitekit-polyfills-********************.js 227 B 0 B
dist/assets/js/googlesitekit-settings-********************.js 90.1 kB 0 B
dist/assets/js/googlesitekit-splash-********************.js 74.2 kB 0 B
dist/assets/js/googlesitekit-user-input-********************.js 62.4 kB 0 B
dist/assets/js/googlesitekit-vendor-********************.js 315 kB 0 B
dist/assets/js/googlesitekit-vendor-lazy-pdf-********************.js 24.6 kB 0 B
dist/assets/js/googlesitekit-widgets-********************.js 187 kB 0 B
dist/assets/js/googlesitekit-wp-dashboard-********************.js 47.7 kB 0 B
dist/assets/js/runtime-********************.js 1.98 kB 0 B
dist/assets/js/sign-in-with-google-********************.js 1.35 kB 0 B

compressed-size-action

@zutigrm
zutigrm merged commit f3fb123 into develop Nov 18, 2026
44 of 45 checks passed
@zutigrm
zutigrm deleted the bug/14112-latest-post-tile-headings branch November 18, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest post performance — tile titles are level 3 headings, the same level as the section title

2 participants