Repository navigation
Fix the heading level of the latest post performance tile titles - #14201
Merged
Merged
Conversation
The three tiles sit under the level 3 heading "Latest post performance since published". A screen reader now lists their titles inside that section, not beside it. A new test checks the level of each heading in the section. Their look stays the same. Their class styles set the colour, the font size and the margin, which WordPress sets differently for an `h3` and an `h4`.
It named one use, a tile under an `h3` heading. It now says what the prop is, in the words `TableTile` gives the same prop.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the heading levels of the tiles within the LatestPostPerformance component by setting the titleAs prop of LatestPostTile to "h4" so that they render as headings one level below the section's h3 heading. It also updates the JSDoc documentation for TileShellProps and adds a test case in LatestPostPerformance.test.tsx to verify the correct heading levels are rendered. There are no review comments, and I have no feedback to provide.
|
Size Change: 0 B Total Size: 3.55 MB ℹ️ View Unchanged
|
zutigrm
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s):
Relevant technical choices
titleAsinTileShell.tsxnow reads "Heading element of the title,h3by default.", the wordsTableTile.tsxgives the same prop, as asked on the issue.titleinTileShell.tsxand oftitleAsinTableTile.tsxstay as they are, because each says what its prop is, with no one use named.h3andh4styles set differently.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist