Fix floating comments from different perfetto protos - #7647
Merged
Merged
Conversation
TParaschiv
approved these changes
Sep 28, 2026
🎨 Perfetto UI Builds & Tests
|
Contributor
|
LGTM for the detached comments. FYI, two remaining proto_merger issues aren't addressed here: OneofOptions loses reserved/extensions, and trailing comments are moved to the next line. I'd suggest a followup for these fixes as well. |
lucigrigo
approved these changes
Sep 28, 2026
LalitMaganti
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attach to a field or to a message all floating comments. This way they get automatically copied during internal processing.