Skip to content

[opendal] fix build script and update repo URL#15648

Open
tonghuaroot wants to merge 2 commits into
google:masterfrom
tonghuaroot:fix-opendal-fuzz
Open

[opendal] fix build script and update repo URL#15648
tonghuaroot wants to merge 2 commits into
google:masterfrom
tonghuaroot:fix-opendal-fuzz

Conversation

@tonghuaroot

Copy link
Copy Markdown

Summary

The OpenDAL fuzz integration has several issues that prevent effective fuzzing:

  1. build.sh copies fuzz_reader to all output slotsfuzz_writer binary was never deployed
  2. Repo URL is staleincubator-opendal was renamed to opendal
  3. Unused .env files — fuzz targets now fall back to a local fs operator automatically (see fix(fuzz): fall back to fs operator so fuzz targets produce real coverage apache/opendal#7723), so the env-based service configuration is no longer needed

Changes

  • build.sh: loop over actual target names and copy each binary correctly; add new fuzz_path target; remove .env file copies
  • Dockerfile: update git clone URL to apache/opendal
  • project.yaml: update main_repo; add tonghuaroot@gmail.com to auto_ccs
  • Remove .fs.env and .memory.env

Evidence

All four OSS-Fuzz targets currently report 0.26% coverage (harness startup only):
https://introspector.oss-fuzz.com/project-profile?project=opendal

Upstream tracking issue: apache/opendal#7722

- build.sh: copy each fuzz binary to its correct output name instead of
  duplicating fuzz_reader to all slots; add new fuzz_path target; remove
  unused .env files since fuzz targets now fall back to a local fs
  operator when no service is configured (apache/opendal#7723)
- Dockerfile: update clone URL from incubator-opendal to opendal
- project.yaml: update main_repo URL; add tonghuaroot to auto_ccs
@github-actions

Copy link
Copy Markdown

tonghuaroot is a new contributor to projects/opendal. The PR must be approved by known contributors before it can be merged. The past contributors are: hunsche, alexcrichton, dqhl76

@DavidKorczynski

Copy link
Copy Markdown
Collaborator

can you let us know when the upstream is ready to land this?

@DavidKorczynski DavidKorczynski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

above comment

@tonghuaroot

Copy link
Copy Markdown
Author

Hi @DavidKorczynski — the upstream piece is apache/opendal#7723. It adds the fuzz_from_uri and fuzz_path targets and makes all four targets fall back to the fs operator so they actually exercise code (the targets had effectively been no-ops since integration — apache/opendal#7722). CI is green there and it's only waiting on a maintainer review. I'll ping you here the moment it merges; this PR's build.sh already builds exactly those four binaries, so it should be good to land right after. Thanks for your patience!

- "dqhl76@gmail.com"
- "ouyangjun1999@gmail.com"
- "suyanhanx@gmail.com"
- "tonghuaroot@gmail.com"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you a maintainer? If not, can you please get approval from maintainers that you can add your email or just remove your email from the list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants