Add contents: read to base-OS and ubuntu-sync check workflows#15500
Open
arpitjain099 wants to merge 1 commit into
Open
Add contents: read to base-OS and ubuntu-sync check workflows#15500arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
dea5a9c to
ad89adc
Compare
Contributor
Author
|
Hi @DavidKorczynski, gentle ping on this. PR has been open for 4 days without review. I noticed you've been on the recent-merger side of recent merges in this repo. When you have a moment, would you mind giving it a quick look? No urgency. Happy to address any feedback. |
Contributor
Author
|
Just checking in on this. Let me know if anything needs tweaking before it can be considered. |
Both workflows fire on pull_request, check out the repo, and run shell/python diff scripts to validate that legacy and versioned base-OS files stay in sync. Neither pushes or comments back to the PR - contents: read is the right scope. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
force-pushed
the
ci/add-permissions
branch
from
5b5b7ec to
5e7fe97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing pull_request validators (
check_base_os.ymlandubuntu_version_sync.yml) currently leave theirGITHUB_TOKENscope at the repository default. Both just:actions/checkout)exit 1on mismatchNeither posts a comment, pushes a commit, or calls any GitHub write endpoint. Declaring
contents: readmakes the minimum scope explicit and matches what other workflows in this repo do.YAML parses cleanly.