Always act as if contacts are prohibited#2897
Conversation
de1434b to
2357c4c
Compare
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu reviewed 180 of 180 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gbrodman)
core/src/main/java/google/registry/batch/RemoveAllDomainContactsAction.java line 112 at r1 (raw file):
tm().transact(() -> FeatureFlag.isActiveNow(MINIMUM_DATASET_CONTACTS_PROHIBITED)), "Minimum dataset migration must be completed prior to running this action"); response.setContentType(PLAIN_TEXT_UTF_8);
Should this line remain?
Code quote:
response.setContentType(PLAIN_TEXT_UTF_8);
gbrodman
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @weiminyu)
core/src/main/java/google/registry/batch/RemoveAllDomainContactsAction.java line 112 at r1 (raw file):
Previously, weiminyu (Weimin Yu) wrote…
Should this line remain?
yeah probably, though this entire action is deleted in #2872
This PR finds instances where we previously checked if the feature flag for contacts-prohibited was set and removes those checks, making the contacts-prohibited behavior the only behavior. Because the tests didn't have that feature flag set, this means we need to change a ton of tests to remove contact references.
2357c4c to
5d9d89e
Compare
weiminyu
left a comment
There was a problem hiding this comment.
@weiminyu reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
This PR finds instances where we previously checked if the feature flag for contacts-prohibited was set and removes those checks, making the contacts-prohibited behavior the only behavior. Because the tests didn't have that feature flag set, this means we need to change a ton of tests to remove contact references.
This PR finds instances where we previously checked if the feature flag for contacts-prohibited was set and removes those checks, making the contacts-prohibited behavior the only behavior. Because the tests didn't have that feature flag set, this means we need to change a ton of tests to remove contact references.
This change is