Reassign xml namespace tags in Fee extensions#2885
Open
weiminyu wants to merge 1 commit intogoogle:masterfrom
Open
Reassign xml namespace tags in Fee extensions#2885weiminyu wants to merge 1 commit intogoogle:masterfrom
weiminyu wants to merge 1 commit intogoogle:masterfrom
Conversation
Nomulus supports multiple Fee extensions, and use hardcoded version-specific namespace tags for each version. Previously the mapping is as follows: - Draft 06 --> 'fee' - Draft 11 --> 'fee11' - Draft 12 --> 'fee12' When we added support for the final standard in RFC 8748, we assigned it 'fee_1_00'. Some customers are having trouble with this new tag. We propose to change the mappings to: - Draft 06 --> 'fee06' - Draft 11 --> 'fee11' - Draft 12 --> 'fee12' - Standard 1.0 -> 'fee' Note that this only affects clients whose XML parsing is not namespace-aware. Our XML is valid before AND after this change.
CydeWeys
approved these changes
Nov 13, 2025
Collaborator
Author
|
See b/458403981. We may not need this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nomulus supports multiple Fee extensions, and use hardcoded version-specific namespace tags for each version. Previously the mapping is as follows:
When we added support for the final standard in RFC 8748, we assigned it 'fee_1_00'.
Some customers are having trouble with this new tag. We propose to change the mappings to:
Note that this only affects clients whose XML parsing is not namespace-aware. Our XML is valid before AND after this change.
This change is