fix #5026 issue and refactor ModelScene.ts#5101
Conversation
diegoteran
left a comment
diegoteran
left a comment
There was a problem hiding this comment.
Thank you, looks good. would just appreciate the warnings to stay.
|
@mohammadbaghaei thanks for the contribution! I'll merge it soon. If you are not currently covered under a CLA, please visit https://cla.developers.google.com/. Once you've signed, follow the "New Contributors" link at the bottom of this page to update this check. |
It seems correct, I don't know why it gives a validation error. |
It shows two different users adding commits when it is only you. They both have the same email but one user has your account username and the other doesn't. 
There might be a key difference in how you are pushing the commit. |
mohammadbaghaei
force-pushed
the
fix-reverse-animation-play
branch
from
95d58eb to
5195a36
Compare
diegoteran
left a comment
diegoteran
left a comment
There was a problem hiding this comment.
thank you so much!
Next time please use the clang-format, I'll fix it this time.
2 participants
No description provided.