feat(secops-soar): improve error message and docs for SOAR certifi issue#238
Open
s1v4-d wants to merge 1 commit intogoogle:mainfrom
Open
feat(secops-soar): improve error message and docs for SOAR certifi issue#238s1v4-d wants to merge 1 commit intogoogle:mainfrom
s1v4-d wants to merge 1 commit intogoogle:mainfrom
Conversation
Catch SSL certificate verification errors in the SOAR MCP server and display actionable error messages instead of the generic 'Failed to fetch valid scopes from SOAR' message. - Add SoarSSLError and SoarConnectionError custom exceptions in http_client.py - Add _is_cert_verify_error() helper that walks the exception cause chain - Add _handle_ssl_error() to detect and re-raise SSL/connection errors with platform-aware fix instructions (macOS Install Certificates.command, pip install certifi) - Update bindings.py and server.py to propagate and log specific error types - Add SSL_CERTIFI_ERROR_MESSAGE, CONNECTION_ERROR_MESSAGE, and CREDENTIALS_ERROR_MESSAGE constants to consts.py - Add Troubleshooting section to server/secops-soar/README.md - Add SOAR SSL troubleshooting note to root README.md - Add 20 unit tests covering all error paths (SSL cert verify, generic SSL, connection refused, bad credentials, message content quality) Closes google#191
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch SSL certificate verification errors in the SOAR MCP server and display actionable error messages instead of the generic 'Failed to fetch valid scopes from SOAR' message.
Closes #191