Specify a version for maven-deploy-plugin, even though we don't use that plugin.#460
Merged
copybara-service[bot] merged 1 commit intomasterfrom Jan 13, 2026
Merged
Conversation
… that plugin. Compare cl/855265235 / google/guava#8163. As with Guava, this should fix [a JDiff breakage](https://github.com/google/jimfs/actions/runs/20968696648/job/60266138089#step:5:491) that is preventing us from deploying snapshot docs. (I'd forgotten that we run JDiff for jimfs!) I would guess that some of our other projects are likewise seeing warnings for the lack of a `maven-deploy-plugin` version, and it might be nice to fix them. But I didn't find any examples in the couple projects I looked at, in part because those projects don't have a JDiff step to fail as a result. (The irony is that we have this problem only because we tried to get the version number from Maven in the Correct way instead of parsing XML with regular expressions :)) RELNOTES=n/a PiperOrigin-RevId: 855836740
copybara-service
bot
force-pushed
the
test_855804267
branch
from
a64cac0 to
94a4d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify a version for
maven-deploy-plugin, even though we don't use that plugin.Compare cl/855265235 / google/guava#8163.
As with Guava, this should fix a JDiff breakage that is preventing us from deploying snapshot docs. (I'd forgotten that we run JDiff for jimfs!)
I would guess that some of our other projects are likewise seeing warnings for the lack of a
maven-deploy-pluginversion, and it might be nice to fix them. But I didn't find any examples in the couple projects I looked at, in part because those projects don't have a JDiff step to fail as a result.(The irony is that we have this problem only because we tried to get the version number from Maven in the Correct way instead of parsing XML with regular expressions :))
RELNOTES=n/a