This repository was archived by the owner on Jun 20, 2025. It is now read-only.
Open
Conversation
iteriani
reviewed
Mar 7, 2021
| assertNoUnclosedTags(currentParent, endNode); | ||
| } | ||
| } | ||
| if (currentNode && currentNode.nextSibling !== endNode) { |
Contributor
There was a problem hiding this comment.
It should be possible to have unvisited dom but currentNode.nextSibling === endNode.
{template a}
Author
There was a problem hiding this comment.
Can you expand on that a bit? What would the unvisited DOM be? What are the idom opcode that produce it?
Contributor
There was a problem hiding this comment.
It should be
function fn(a:boolean) {
elementOpen('div', 1);
elementClose();
if (a) {
elementOpen('div', 2);
elementClose();
} else {
elementOpen('div', 3);
elementClose();
}
elementOpen('div', 4);
elementClose();
}
In the first route (A), you'd have
if you flip a to false, you'd first have, I think, the following behavior
<-- insertthen the jump to 4
<-- insert <--and then never deleting [key=2]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
patchBetween(startNode, endNode, template, data)function that can run a patch function in between two nodes.