This repository was archived by the owner on Apr 18, 2026. It is now read-only.
Filter for haskell_binary|library|test#12
Open
aherrmann wants to merge 1 commit intogoogle:masterfrom
Open
Conversation
Contributor
|
Furthermore, this should help when running on big directories that otherwise leads to |
These are the only kinds of targets that produce the `compile_info_output_groups` that `hrepl` requires. This is to avoid errors if non-Haskell targets are picked up as intermediate dependencies between targets specified on the command-line, e.g. through `data` dependencies. Additionally, this enables users to call `hrepl` on wild-card targets. E.g. in the `rules_haskell` repository ``` hrepl //tests/binary-with-lib:all ``` Now no longer fails on with an error of the form ``` hrepl: .../tests/binary-with-lib/binary-with-lib@repl.HaskellCompile.pb: openBinaryFile: does not exist (No such file or directory) ```
aherrmann
force-pushed
the
haskell-filter
branch
from
d2342e1 to
b5e1fea
Compare
Author
|
Rebased on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
These are the only kinds of targets that produce the
compile_info_output_groupsthathreplrequires. This is to avoid errors if non-Haskell targets are picked up as intermediate dependencies between targets specified on the command-line, e.g. throughdatadependencies. See #10.This also enables users to call
hreplon wild-card targets. E.g. in therules_haskellrepositoryNow no longer fails on with an error of the form