Skip to content

Water High/Low Level Alarms #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ciaran-Oflannagain wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Water High/Low Level Alarms #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
135de26
Water High/Low Level Alarms
Ciaran-Oflannagain Jul 7, 2025
340a44b
Merge branch 'master' into water_level_alarms_2025_07_07
shambersafai Jul 7, 2025
13add57
add water alarms to telemetry fields
Ciaran-Oflannagain Jul 8, 2025
27752f1
Merge branch 'master' into water_level_alarms_2025_07_07
shambersafai Aug 21, 2025
a8a1a45
Merge branch 'master' into water_level_alarms_2025_07_07
shambersafai Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8709,6 +8709,9 @@ LHLM:
guid: "647a4576-b503-43cd-b3b7-e1a9c6856695"
description: "High and Low Level Monitoring for tanks."
is_abstract: true
opt_uses:
- water_high_level_alarm
- water_low_level_alarm
uses:
- water_high_level_status
- water_low_level_status
Expand Down
6 changes: 6 additions & 0 deletions ontology/yaml/resources/fields/telemetry_fields.yaml
View file
Open in desktop
Copy link
Copy Markdown
Member

@shambersafai shambersafai Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move these above the statuses to alphabetize

Original file line number Diff line number Diff line change
Expand Up @@ -4028,6 +4028,9 @@ literals:
- water_high_level_status:
- ACTIVE
- INACTIVE
- water_high_level_alarm:
- ACTIVE
- INACTIVE
- water_leak_alarm:
- ACTIVE
- INACTIVE
Expand All @@ -4050,6 +4053,9 @@ literals:
- water_low_level_status:
- ACTIVE
- INACTIVE
- water_low_level_alarm:
- ACTIVE
- INACTIVE
- water_riser_mode:
- OFF
- HEATING
Expand Down