crubit: bump Rust edition to 2024 for generated Rust sources#796
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
crubit: bump Rust edition to 2024 for generated Rust sources#796copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
This was set to 2018 in 2021 without much comment presumably as a way to hedge against edition changes breaking things. I'm not sure if we should hard-code it here, or just let it "float" to the global default edition, so for now I'm just bumping it to 2024 and kicking the can at least a year down the road. PiperOrigin-RevId: 894062743
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crubit: bump Rust edition to 2024 for generated Rust sources
This was set to 2018 in 2021 without much comment presumably as a way to
hedge against edition changes breaking things. I'm not sure if we should
hard-code it here, or just let it "float" to the global default edition,
so for now I'm just bumping it to 2024 and kicking the can at least a
year down the road.