-
Notifications
You must be signed in to change notification settings - Fork 600
Add handling for reformatted archives conditional on archive format version #5145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
letitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round. I'm excited to see this land!
letitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smaller comments this time around, except that we still need tests :)
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Show resolved
Hide resolved
| to_extract = [f.name for f in to_extract] | ||
| self.assertCountEqual(to_extract, needed_files) | ||
|
|
||
| @parameterized.parameterized.expand(['/b/build/', 'build/', '']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why delete this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, this is actually something I meant to ask about but forgot over the weekend... this test seems exactly the same as the test that proceeds it other than in name. Do you happen to know if the test case is still relevant?
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Show resolved
Hide resolved
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Outdated
Show resolved
Hide resolved
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Outdated
Show resolved
Hide resolved
|
Can you please explain me simply briefly in my reply. What's this about?
And what should I do?
And is there any else to fixed by my side , because there are lots of
coding samples you give me,, kindly just tell me what should I do
…On Fri, 30 Jan 2026, 23:50 Martin Verde, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
<#5145 (comment)>:
> @@ -245,11 +290,50 @@ def test_other_fuzzer_not_extracted(self, dir_prefix):
to_extract = [f.name for f in to_extract]
self.assertCountEqual(to_extract, needed_files)
+ @parameterized.parameterized.expand(['/b/build/', 'build/', ''])
+ def test_possible_dependencies(self, dir_prefix):
+ """Tests that all the necessary dependencies are correctly extracted from
+ the runtime_deps file.
+
+ Under the current archive schema, dependency paths in `runtime_deps` files
Done.
—
Reply to this email directly, view it on GitHub
<#5145 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B332O6OI26BTIHVLDP7TJP34JOKU7AVCNFSM6AAAAACTARK4KKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOMRZGYZTKMZZGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
letitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there!
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Outdated
Show resolved
Hide resolved
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Show resolved
Hide resolved
| """ | ||
| self._set_archive_schema_version(1) | ||
| deps_entries = self._generate_possible_fuzzer_dependencies('my_fuzzer') | ||
| deps_files = self._generate_normalized_dependency_filenames( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function calls _generate_possible_fuzzer_dependencies() again even though we just did on the line above. How about passing in a list of relative paths directly, and calling this something like _resolve_relative_dependency_paths(fuzz_target_path, dependency_paths)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did something similar... how does this look?
src/clusterfuzz/_internal/tests/core/build_management/build_archive_test.py
Outdated
Show resolved
Hide resolved
cemon721-a11y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! Using getattr() to handle the missing attribute looks like the right approach. This will unblock our workflow." And if I did again some mistakes the kindly please Send Simply inbox To my Gmail address.
Opening on behalf of @mverde to start reviewing early.