refactor(vm): move vm Config to cli crate #376
Merged
+141
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lencerf
force-pushed
the
refactor/vm-config
branch
from
244c471 to
d0ff051
Compare
Pull Request Test Coverage Report for Build 21500373191Details
💛 - Coveralls |
Lencerf
force-pushed
the
refactor/vm-config
branch
5 times, most recently
from
5ae57fa to
71657cc
Compare
The alioth library should provide composable building blocks for creating virtual machines, but the specific configuration and shape of a VM should be defined by the application layer. This commit moves the vm::Config struct from the alioth library to the alioth-cli crate to better enforce this separation of concerns. This makes the library more flexible and reusable. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Lencerf
force-pushed
the
refactor/vm-config
branch
from
71657cc to
a0e08d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.