Skip to content

fix: use userId from eval result to prevent session 404 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
brucearctor wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Draft

fix: use userId from eval result to prevent session 404 #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/app/components/eval-tab/eval-tab.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ interface EvaluationResult {
evalMetricResults: any[];
overallEvalMetricResults: any[];
evalMetricResultPerInvocation?: any[];
userId: string;
sessionId: string;
sessionDetails: any;
}
Expand Down Expand Up @@ -385,7 +386,11 @@ export class EvalTabComponent implements OnInit, OnChanges {
this.currentEvalResultBySet.get(this.selectedEvalSet)
?.filter((c) => c.evalId == evalId)[0];
const sessionId = evalCaseResult!.sessionId;
this.sessionService.getSession(this.userId(), this.appName(), sessionId)
// Use the userId from the eval result instead of the component-level
// userId to avoid session 404 errors when the eval runner creates
// sessions with a different user_id than the UI default.
const evalUserId = evalCaseResult!.userId || this.userId();
this.sessionService.getSession(evalUserId, this.appName(), sessionId)
.subscribe((res) => {
this.addEvalCaseResultToEvents(res, evalCaseResult!);
const session = this.fromApiResultToSession(res);
Expand Down Expand Up @@ -545,6 +550,7 @@ export class EvalTabComponent implements OnInit, OnChanges {
evalMetricResults: result.evalMetricResults,
evalMetricResultPerInvocation:
result.evalMetricResultPerInvocation,
userId: result.userId,
sessionId: result.sessionId,
sessionDetails: result.sessionDetails,
overallEvalMetricResults:
Expand Down