fix(sessions): ignore in-memory partial events#345
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InMemorySessionService.appendEventfor partial streaming eventslastUpdateTimeValidation
npm installnpm run build --workspace corenpx vitest run --project unit:core --dir core/test/sessions in_memory_session_service_test.tsnpx prettier --check core/src/sessions/in_memory_session_service.ts core/test/sessions/in_memory_session_service_test.tsnpx eslint core/src/sessions/in_memory_session_service.ts core/test/sessions/in_memory_session_service_test.tsgit diff --checkNotes
npx vitest run --project unit:core core/test/sessions/in_memory_session_service_test.tsfailed before building because global setup imports@google/adkfrom missingdist; building core first resolved it.npm installreports existing audit findings in dependencies: 9 low, 4 moderate, 13 high.