Changes so scripts can run on Cloud DataFlow#264
Open
langmore wants to merge 6 commits intogoogle-research:mainfrom
Open
Changes so scripts can run on Cloud DataFlow#264langmore wants to merge 6 commits intogoogle-research:mainfrom
langmore wants to merge 6 commits intogoogle-research:mainfrom
Conversation
Collaborator
|
There are some errors in the tests, maybe you can take a look. |
Contributor
Author
|
I updated I also tweaked the deps for beam, added to .gitignore, and re-tested. Let's hope the pipeline passes this time. |
Contributor
Author
|
@raspstephan Things should be good now. The errors were associated with the xarray update (recall I fixed that for WBX, and used the same change here). I can't run the pipeline though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.py: Changed dependences by moving some deps intobase_requiresscripts/slice_dataset.py: AddedMAX_MEMbecause GCP users want to save money and use a smaller instance. Added_assert_nonzero_slicesto catch a common user misspecification.scripts/compute_probabilistic_climatological_forecasts.py: AddedMAX_MEMas above. Moved someFLAGSout of lambdas, so their value can be found on workers.