Misc. fixes for newer versions of Xarray#182
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Misc. fixes for newer versions of Xarray#182copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_671238424
branch
from
e70d9a3 to
44dd4dc
Compare
These fixes fall into three categories: 1. Xarray's groupby no longer supports squeezing out size 1 dimensions. Instead, I've set `squeeze=False` and added explicit calls to `.squeeze()`. 2. Slight differences in dtypes/rounding (I believe these are indirectly due to changes required for NumPy 2.0 compatibility). 3. Various cases where type checking is stricter (I've added `type: ignore` to these lines) PiperOrigin-RevId: 671238424
copybara-service
bot
force-pushed
the
test_671238424
branch
from
44dd4dc to
5461f2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc. fixes for newer versions of Xarray
These fixes fall into three categories:
Instead, I've set
squeeze=Falseand added explicit calls to.squeeze().changes required for NumPy 2.0 compatibility).
type: ignoretothese lines)