fix(builder): use buildctl-supported import/export cache flags#2599
Merged
Conversation
buildctl build does not recognize buildx-style --cache-from/--cache-to flags, causing every Dockerfile build to fail with "flag provided but not defined: -cache-from". Switch the local layer cache args to --import-cache/--export-cache as documented by buildctl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flag provided but not defined: -cache-frombecause the local BuildKit layer-cache args used buildx-style--cache-from/--cache-to, whichbuildctl builddoes not support.localBuildKitCacheArgsto buildctl's--import-cache/--export-cache(type=local, mode=max), keeping the same per-service cache directory layout.Test plan
go test ./builder/build/ -run TestLocalBuildKitCacheArgsgo build ./builder/...andgo vet ./builder/build/