fix(builder): add timeouts to mirror pull client and probe real maninfest path#2598
Merged
Merged
Conversation
…est path A mirror that passed the /v2/ liveness probe (docker.xuanyuan.me) accepted connections but never answered manifest requests for some images, and the mirror RegistryHost client had no timeouts while the containerd pull path has no outer context deadline -- builds hung indefinitely. Add dial/TLS/ response-header timeouts so a stalling mirror costs at most ~30s before the resolver falls through to the next host. Probe a real manifest path (200 or 401 alive) so ping-only frontends are exercised end to end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mirror that passed the /v2/ liveness probe (docker.xuanyuan.me) accepted connections but never answered manifest requests for some images, and the mirror RegistryHost client had no timeouts while the containerd pull path has no outer context deadline -- builds hung indefinitely. Add dial/TLS/ response-header timeouts so a stalling mirror costs at most ~30s before the resolver falls through to the next host. Probe a real manifest path (200 or 401 alive) so ping-only frontends are exercised end to end.