Skip to content

fix(test-manifest): register missing capabilities to unblock CI#2594

Merged
yangkaa merged 2 commits into
goodrain:mainfrom
yangkaa:agent8
Jun 12, 2026
Merged

fix(test-manifest): register missing capabilities to unblock CI#2594
yangkaa merged 2 commits into
goodrain:mainfrom
yangkaa:agent8

Conversation

@yangkaa

@yangkaa yangkaa commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

What

The Check test manifest CI step (make test-manifest-check) was failing on main because three managed tests carry capability_id markers that were never registered in test-manifest.json:

  • rainbond.dockerfile-build.registry-mirror-tomlbuilder/sources/buildkit_toml_test.go
  • rainbond.upgrade-configmap-aggregates-create-update-errorsworker/appm/controller/upgrade_test.go
  • rainbond.upgrade-service-aggregates-create-update-errorsworker/appm/controller/upgrade_test.go

Reference failing run: https://github.com/goodrain/rainbond/actions/runs/27359033207/job/80841118118

Changes

  • test-manifest.json: register the three capabilities (interface / code_paths / tests), inserted in sorted order.
  • test-manifest.md: regenerated via scripts/manage_test_manifest.py render to stay in sync.
  • CLAUDE.md / AGENTS.md: document the CI-enforced test-manifest workflow so future managed tests are registered with scripts/manage_test_manifest.py add instead of hand-editing the manifest (which is what caused this failure).

Test plan

  • make test-manifest-checktest manifest validation passed for rainbond
  • python3 -c "import json; json.load(open('test-manifest.json'))" → valid JSON
  • No reformatting churn: diff is additive only (+163 lines across 4 files)

yangkaa added 2 commits June 12, 2026 09:03
…de error aggregation tests

Signed-off-by: yangk <yangk@goodrain.com>
Signed-off-by: yangk <yangk@goodrain.com>
@yangkaa yangkaa merged commit 9eab9dd into goodrain:main Jun 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant