fix(test-manifest): register missing capabilities to unblock CI#2594
Merged
Conversation
…de error aggregation tests Signed-off-by: yangk <yangk@goodrain.com>
Signed-off-by: yangk <yangk@goodrain.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
Check test manifestCI step (make test-manifest-check) was failing onmainbecause three managed tests carrycapability_idmarkers that were never registered intest-manifest.json:rainbond.dockerfile-build.registry-mirror-toml—builder/sources/buildkit_toml_test.gorainbond.upgrade-configmap-aggregates-create-update-errors—worker/appm/controller/upgrade_test.gorainbond.upgrade-service-aggregates-create-update-errors—worker/appm/controller/upgrade_test.goReference failing run: https://github.com/goodrain/rainbond/actions/runs/27359033207/job/80841118118
Changes
test-manifest.json: register the three capabilities (interface / code_paths / tests), inserted in sorted order.test-manifest.md: regenerated viascripts/manage_test_manifest.py renderto stay in sync.CLAUDE.md/AGENTS.md: document the CI-enforced test-manifest workflow so future managed tests are registered withscripts/manage_test_manifest.py addinstead of hand-editing the manifest (which is what caused this failure).Test plan
make test-manifest-check→test manifest validation passed for rainbondpython3 -c "import json; json.load(open('test-manifest.json'))"→ valid JSON