Merged
Conversation
If a read/write callback function raises an exception, we're going to allow that without rescuing. There are no stateful processes in ModBoss that the exception might mess up; it's just the caller's processes that might suffer. If a user of this library wants to protect against exceptions, they can always wrap the logic of their callback function in a try/rescue and return an error tuple to ModBoss if an exception was raised. For example, that would allow ModBoss to retry up to max_attempts. ModBoss retries to occur.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided against rescuing exceptions in user-provided callbacks for now. There are no stateful processes we need to protect in ModBoss, so it's up to the user to decide if they want to wrap their own logic in a try/rescue.