Fixed issue with "chart" directive and "type" attribute throwing an exception and not reading in chart type#58
Open
jstol wants to merge 1 commit intogonewandering:masterfrom
Open
Fixed issue with "chart" directive and "type" attribute throwing an exception and not reading in chart type#58jstol wants to merge 1 commit intogonewandering:masterfrom
jstol wants to merge 1 commit intogonewandering:masterfrom
Conversation
…xception and not reading in chart type Originally, using the general "chart" directive (as opposed to a specific directive such as "linechart" or "barchart"), and the described "type" attribute caused an exception to be thrown (TypeError: undefined is not a function), and stopped the chart from being rendered at all. This was due to the fact that there was no "type" attribute defined in the directive's isolated scope. Looking at the code, it seemed as if though the chart type was expected to be specified in an attribute "chart", not an attribute "type". This "chart" attribute bound to the directive's isolated scope was changed to "type", and it no longer causes an exception to be thrown and allows the charts to be rendered as expected. See issue gonewandering#52 (gonewandering#52) for the original reported issue.
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, using the general
chartdirective (as opposed to a specific directive such aslinechartorbarchart), and the describedtypeattribute caused an exception to be thrown (TypeError: undefined is not a function), and stopped the chart from being rendered at all. This was due to the fact that there was notypeattribute defined in the directive's isolated scope. Looking at the code, it seemed as if though the chart type was expected to be specified in an attributechart(which is currently also a directive name), not an attributetype. Thischartattribute bound to the directive's isolated scope was changed totype, and it no longer causes an exception to be thrown and allows the charts to be rendered as expected.See issue #52 for the original reported issue.