Fix bug tickets: session-not-found, in-flight rows, markdown/UI (#17, #26, #27)#29
Open
goncharik wants to merge 13 commits into
Open
Fix bug tickets: session-not-found, in-flight rows, markdown/UI (#17, #26, #27)#29goncharik wants to merge 13 commits into
goncharik wants to merge 13 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three open
bug-tagged issues: #17, #26, #27.Note
This branch is stacked on
push-notifications(not yet merged tomain). Targetingmainas requested, so the diff currently also includes the push-notifications commits. Either mergepush-notificationsfirst (the diff then collapses to just the bug fixes), or re-point this PR's base topush-notificationsfor a bug-fix-only review.#17 — "session not found" on the next RPC after background→foreground
GatewayError.isSessionNotFound.prompt.submit, attach uploads,session.titlerename) now self-heal: on a server "session not found" they re-resume the stored session for a freshliveSessionID— orsession.createwhen there's no stored id (the fresh-session root cause) — then replay the RPC once; the banner shows only if the heal or retry also fails. Foregroundsession.resume"session not found" now recreates instead of being silently swallowed. SharedwithSessionHealhelper.#26 — in-flight thinking / tool-call rows vanished on background→foreground
inflightpayload carries only user/assistant text — no reasoning/tools), re-appending them after the authoritative history; completed turns still replace wholesale. Elapsed timer resumes instead of restarting.#27 — markdown support + chat UI restructure
MarkdownSegment, rendered inMarkdownText; fenced code still takes precedence; malformed markup degrades to prose)..textSelection).Tests
GatewayErrorTests,SelfHealTests(11),ChatRowCopyTests; extendedHydrateTests,MarkdownSegmentTests.Manual verification still needed (background→foreground is not automatable here)