Conversation
|
@marwan-at-work can you help to take a look at this PR for docs update? I think you have the most context about Athens NetworkMode |
|
|
||
| 2. `offline`: This mode only retrieves versions from Athens' storage and never reaches out to the VCS. | ||
|
|
||
| 3. `fallback`: This mode retrieves versions from Athens' storage only if the VCS fails. Note that using this mode may result in inconsistent results since fallback mode does its best to provide the available versions at the time of the request. |
There was a problem hiding this comment.
This mode retrieves versions from Athens' storage only if the VCS fails.
I don't believe that's true. We always retrieve versions from the Athens storage. We just fallback to only providing this list in case of an upstream outage
There was a problem hiding this comment.
We always retrieve versions from the Athens storage
Hmm sorry, I don't exactly follow
- This was taken from this snippet.
- That aside, I can attest this behavior is correct based on existing live deployments
- Also referring to /pkg/download/protocol.go
maybe I could have worded it better? 🤔
edit: AFAIK go get will reach out to VCS to retrieve versions. But commands like go mod download and go build will always return whatever that is from Athens storage
There was a problem hiding this comment.
@marwan-at-work WDYT? can you recommend what can I change here to move this PR forward?
9306eee to
e0a7805
Compare
What is the problem I am trying to address?
helmCLI installation instructionTo run this locally, just check out this branch and run
hugo serve -s docsat the repository root.