Starting for for encryption feature for issue # 1539 #1542
Open
wburningham wants to merge 2 commits intogomods:mainfrom
Open
Starting for for encryption feature for issue # 1539 #1542wburningham wants to merge 2 commits intogomods:mainfrom
wburningham wants to merge 2 commits intogomods:mainfrom
Conversation
Member
|
@wburningham Since you put "starting" in the title, I didn't do a thorough review - just quickly skimmed the code. It looks like a good start. Would you like a complete review now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
storage.Backendto encrypt and decrypt data.StorageEncryptionKeyconfig option to set an encryption key and enable encryption.Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
Fixes #1539