Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # stable
with:
toolchain: stable
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify checkout steps missing persist-credentials hardening.
rg -n -C2 'uses:\s*actions/checkout@' .github/workflows \
  && rg -n -C2 'persist-credentials:\s*false' .github/workflows

Repository: gominimal/kittyview

Length of output: 772


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== release.yml around checkout (lines 30-80) ==="
nl -ba .github/workflows/release.yml | sed -n '30,90p'

echo
echo "=== Any artifact handling in release.yml ==="
rg -n "upload-artifact|download-artifact|artifact" .github/workflows/release.yml || true

echo
echo "=== Any other checkout steps with persist-credentials in workflows ==="
rg -n "persist-credentials:" .github/workflows || true

Repository: gominimal/kittyview

Length of output: 174


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== release.yml around checkout (lines 30-80) ==="
awk 'NR>=30 && NR<=80 {print NR ":" $0}' .github/workflows/release.yml

echo
echo "=== Any artifact handling in release.yml ==="
rg -n "upload-artifact|download-artifact|artifact" .github/workflows/release.yml || true

echo
echo "=== Any checkout steps with persist-credentials in workflows ==="
rg -n "persist-credentials:" .github/workflows || true

Repository: gominimal/kittyview

Length of output: 2226


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== release.yml lines 70-160 ==="
awk 'NR>=70 && NR<=160 {print NR ":" $0}' .github/workflows/release.yml

echo
echo "=== Any actions/checkout@ usage in release.yml ==="
rg -n "uses:\s*actions/checkout@" .github/workflows/release.yml

Repository: gominimal/kittyview

Length of output: 1138


Add persist-credentials: false to checkout in the release workflow.

actions/checkout in the build job (line 42) runs before artifact packaging/upload, and it currently doesn’t disable persisting the token to the local git config.

Suggested patch
-      - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+      - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
+        with:
+          persist-credentials: false
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
with:
persist-credentials: false
🧰 Tools
🪛 zizmor (1.25.2)

[warning] 42-42: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml at line 42, The checkout step using "uses:
actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10" in the release
workflow should set persist-credentials: false; update the checkout step in the
build job to include persist-credentials: false so the workflow does not persist
the GITHUB_TOKEN to local git config (keep the same uses reference and add the
persist-credentials key under that step).

Source: Linters/SAST tools


- uses: dtolnay/rust-toolchain@3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 # stable
with:
Expand Down
Loading