Skip to content

ci(standards): renew the GPU tidy-coverage exceptions, drop codespell - #27

Open
lusoris wants to merge 2 commits into
mainfrom
fix/expired-exceptions
Open

lusoris wants to merge 2 commits into
mainfrom
fix/expired-exceptions

Conversation

@lusoris

@lusoris lusoris commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Twelve exceptions in .standards.yaml expired on 2026-11-01, so the audit, and every commit hook that runs it, fails on main.

  • Renewed (11): the clang-tidy-coverage entries for the CUDA, HIP, Metal, SYCL, fuzz and Vulkan example sources. No GPU toolchain lane exists yet, so they stay excused as category C for ten days (entered 2026-11-05, expires 2026-11-15).
  • Removed (1): the codespell entry for .config/agent/hooks/block_evasion.py. codespell on that file now exits 0, so the entry excuses nothing.

The engine audit passes with this change; ci tidy-coverage still needs the renewed entries in CI, where the compile database exists.

Signed-off-by: lusoris lusoris@proton.me

Summary by Sourcery

Renew temporary GPU coverage exceptions and remove the no-longer-needed codespell exemption so standards checks pass.

Bug Fixes:

  • Restore standards audits and commit hooks by renewing expired GPU clang-tidy coverage exceptions.

Enhancements:

  • Update the standards exception metadata for CUDA, HIP, Metal, SYCL, fuzzing, and Vulkan sources to reflect their temporary category C status.
  • Remove the obsolete codespell exception now that the affected hook passes codespell checks.

Chores:

  • Refresh codespell configuration alongside the standards exception updates.

Summary by CodeRabbit

  • Chores
    • Updated static-analysis exception records, including renewal dates and explanations for existing coverage exceptions.
    • Removed an expired spell-check exception, so the affected file is now included in spell-checking unless another skip rule applies.
    • Added a word to the spell-checker’s accepted-word list.
    • No user-facing functionality changes.

The eleven clang-tidy-coverage entries for the CUDA, HIP, Metal, SYCL,
fuzz and Vulkan sources expired on 2026-11-01 and fail the audit. No
GPU toolchain lane exists yet, so they are renewed as category C for
ten days. The codespell entry for the agent hook is removed: codespell
reports nothing on that file any more.

Signed-off-by: lusoris <lusoris@proton.me>
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The standards files remove an expired codespell exception, renew eleven clang-tidy-coverage exceptions through 2026-11-15, and update the codespell skip and ignore-word lists. The cppcheck exception remains unchanged.

Changes: Standards exceptions

Layer / File(s) Summary
Remove and renew exceptions
.standards.yaml, .codespellrc
The expired codespell exception is removed. Eleven clang-tidy-coverage exceptions receive category C, entry date 2026-11-05, and expiration 2026-11-15. CUDA reasons now state that the exceptions were renewed; other reasons retain their toolchain-lane explanations. .codespellrc no longer skips .config/agent/hooks/block_evasion.py and adds grap to the ignore-word list.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related issues

  • Issue 26 concerns the unavailable libFuzzer toolchain lane for fuzz_dispatch_parse. This PR renews the matching coverage exception but does not change the smoke job's skip behavior.
Merge Risk: Minimal · up to 0f61f

No actionable merge-blocking risk is established by these standards-only changes.

Architecture risk: Low · up to 0f61f

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .standards.yaml: The cppcheck exception remains unchanged. The expired codespell exception for .config/agent/hooks/block_evasion.py was removed.
  • observed — Modified behavior in .standards.yaml: Eleven clang-tidy-coverage exceptions now include category C, entry date 2026-11-05, and expiration 2026-11-15, replacing the prior expiration of 2026-11-01. The CUDA reasons now state that the exceptions were renewed; the other reasons continue to identify their missing toolchain lanes.
  • observed — Modified behavior in .codespellrc: The skip list removes .config/agent/hooks/block_evasion.py, so it is no longer explicitly skipped. The ignore-word list adds grap.
Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the two main changes: renewing GPU clang-tidy-coverage exceptions and removing the codespell exception.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4b8ccb85-106d-42b1-8514-2fdc32c28c78
Commits

Reviewing files that changed from the base of the PR and between 3c1599a and 0f61fde.

Files selected for processing: 1

  • .codespellrc

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

@sourcery-ai

sourcery-ai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

The PR updates the standards exception registry so the audit continues to pass: 11 missing-GPU-toolchain clang-tidy coverage suppressions are renewed as category C exceptions for ten days with refreshed provenance, while the no-longer-needed codespell suppression is removed.

Flow diagram for standards exception audit

flowchart LR
    Registry[.standards.yaml exception registry] --> Audit[Standards audit]
    Audit -->|11 renewed category C entries| Tidy[clang-tidy-coverage exceptions]
    Tidy -->|GPU toolchain lanes unavailable| Suppress[Suppress coverage findings until 2026-11-15]
    Audit -->|codespell entry removed| Codespell[codespell passes for block_evasion.py]
    Audit --> Pass[Engine audit passes]
Loading

File-Level Changes

Change Details Files
Renew the expired GPU clang-tidy coverage exceptions for a short, explicitly categorized window.
  • Add category C and renewal dates of 2026-11-05 through 2026-11-15.
  • Update reasons to document the absent CUDA, HIP, Metal, SYCL, fuzzing, and Vulkan toolchain lanes.
  • Apply the renewal to 11 example and FFmpeg GPU-related source paths.
.standards.yaml
Remove an obsolete codespell exception now that the affected hook passes without suppression.
  • Delete the expired exception for block_evasion.py.
.standards.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

✅ No blocking issues noticed

No blocking implementation issues were identified. The configuration changes should be validated with the standards audit, codespell, and metadata checks for all renewed exceptions.

Test suggestions

  • Run the standards engine audit and verify the updated configuration passes.
  • Run codespell against .config/agent/hooks/block_evasion.py and verify it passes without an exception.
  • Validate that all eleven renewed clang-tidy coverage exceptions have the expected category and expiration metadata.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Run the standards engine audit and verify the updated configuration passes.
2. Run codespell against `.config/agent/hooks/block_evasion.py` and verify it passes without an exception.
3. Validate that all eleven renewed clang-tidy coverage exceptions have the expected category and expiration metadata.

Make this review better

TIP Add a ticket key to the branch or title so the reviewer can check the PR against it. Or tell us which ticket tracker you use here.

TIP How was this review? Give us feedback

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path=".standards.yaml" line_range="46" />
<code_context>
     path: .github/workflows/docker-publish.yml
     reason: adoption found the release workflows short of the declared supply chain (SLSA Build Level 3 declared, Level 2 measured); raise them as docs/guides/releasing.md in Praetor describes, then remove this entry
     expires: "2027-01-20"
-  - rule: codespell
-    path: .config/agent/hooks/block_evasion.py
-    category: C
</code_context>
<issue_to_address>
**Hook spelling errors go unchecked**

When a misspelling is introduced in `.config/agent/hooks/block_evasion.py` and the codespell hook runs, `.codespellrc` still excludes the hook from codespell’s `skip` list, so spelling errors pass CI and pre-commit unnoticed even after the standards exception is removed.

Remove `.config/agent/hooks/block_evasion.py` from `.codespellrc`’s `skip` list so codespell checks the file.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: .standards.yaml:46


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread .standards.yaml Resolved
The standards exception for codespell on .config/agent/hooks/block_evasion.py
was removed, but .codespellrc still skipped the file. Drop the skip entry
and ignore the one deliberate prefix (grap, from the gh api graphql
pattern) so codespell checks the hook.

Signed-off-by: lusoris <lusoris@proton.me>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant