Repository navigation
Conversation
The eleven clang-tidy-coverage entries for the CUDA, HIP, Metal, SYCL, fuzz and Vulkan sources expired on 2026-11-01 and fail the audit. No GPU toolchain lane exists yet, so they are renewed as category C for ten days. The codespell entry for the agent hook is removed: codespell reports nothing on that file any more. Signed-off-by: lusoris <lusoris@proton.me>
Reviewer's GuideThe PR updates the standards exception registry so the audit continues to pass: 11 missing-GPU-toolchain clang-tidy coverage suppressions are renewed as category C exceptions for ten days with refreshed provenance, while the no-longer-needed codespell suppression is removed. Flow diagram for standards exception auditflowchart LR
Registry[.standards.yaml exception registry] --> Audit[Standards audit]
Audit -->|11 renewed category C entries| Tidy[clang-tidy-coverage exceptions]
Tidy -->|GPU toolchain lanes unavailable| Suppress[Suppress coverage findings until 2026-11-15]
Audit -->|codespell entry removed| Codespell[codespell passes for block_evasion.py]
Audit --> Pass[Engine audit passes]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
✅ No blocking issues noticed
No blocking implementation issues were identified. The configuration changes should be validated with the standards audit, codespell, and metadata checks for all renewed exceptions.
Test suggestions
- Run the standards engine audit and verify the updated configuration passes.
- Run codespell against
.config/agent/hooks/block_evasion.pyand verify it passes without an exception. - Validate that all eleven renewed clang-tidy coverage exceptions have the expected category and expiration metadata.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Run the standards engine audit and verify the updated configuration passes.
2. Run codespell against `.config/agent/hooks/block_evasion.py` and verify it passes without an exception.
3. Validate that all eleven renewed clang-tidy coverage exceptions have the expected category and expiration metadata.
Make this review better
TIP Add a ticket key to the branch or title so the reviewer can check the PR against it. Or tell us which ticket tracker you use here.
TIP How was this review? Give us feedback
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".standards.yaml" line_range="46" />
<code_context>
path: .github/workflows/docker-publish.yml
reason: adoption found the release workflows short of the declared supply chain (SLSA Build Level 3 declared, Level 2 measured); raise them as docs/guides/releasing.md in Praetor describes, then remove this entry
expires: "2027-01-20"
- - rule: codespell
- path: .config/agent/hooks/block_evasion.py
- category: C
</code_context>
<issue_to_address>
**Hook spelling errors go unchecked**
When a misspelling is introduced in `.config/agent/hooks/block_evasion.py` and the codespell hook runs, `.codespellrc` still excludes the hook from codespell’s `skip` list, so spelling errors pass CI and pre-commit unnoticed even after the standards exception is removed.
Remove `.config/agent/hooks/block_evasion.py` from `.codespellrc`’s `skip` list so codespell checks the file.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: .standards.yaml:46
The standards exception for codespell on .config/agent/hooks/block_evasion.py was removed, but .codespellrc still skipped the file. Drop the skip entry and ignore the one deliberate prefix (grap, from the gh api graphql pattern) so codespell checks the hook. Signed-off-by: lusoris <lusoris@proton.me>
Twelve exceptions in
.standards.yamlexpired on 2026-11-01, so the audit, and every commit hook that runs it, fails on main..config/agent/hooks/block_evasion.py.codespellon that file now exits 0, so the entry excuses nothing.The engine audit passes with this change;
ci tidy-coveragestill needs the renewed entries in CI, where the compile database exists.Signed-off-by: lusoris lusoris@proton.me
Summary by Sourcery
Renew temporary GPU coverage exceptions and remove the no-longer-needed codespell exemption so standards checks pass.
Bug Fixes:
Enhancements:
Chores:
Summary by CodeRabbit