Skip to content

Lint fixes, helper function - #203

Merged
davidnewhall merged 2 commits into
mainfrom
dn2_lint2
Aug 20, 2026
Merged

Lint fixes, helper function#203
davidnewhall merged 2 commits into
mainfrom
dn2_lint2

Conversation

@davidnewhall

Copy link
Copy Markdown
Contributor

Linter updated and brought some new findings. Some suppressed, some fixed. Added a helper method to deal with duplication of "force save" all over the place.

Also ran go get -u ./... ; go mod tidy

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies linter-driven cleanups, introduces a shared helper for the common forceSave query parameter, and refreshes Go module dependencies/configuration.

Changes:

  • Added starr.ForceSave(bool) helper and replaced repeated url.Values{"forceSave": ...} constructions across *arr clients.
  • Updated .golangci.yml disables/exclusions in response to new linter findings.
  • Ran dependency updates/tidy (go.mod/go.sum), including bumping golang.org/x/net.

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
starrcmd/parser.go Lint-driven change in reflection kind check.
sonarr/metadata.go Use starr.ForceSave for forceSave query construction.
sonarr/indexer.go Replace inline forceSave query values with helper.
sonarr/importlist.go Replace inline forceSave query values with helper.
sonarr/downloadclient.go Replace inline forceSave query values with helper.
readarr/indexer.go Replace inline forceSave query values with helper.
readarr/importlist.go Replace inline forceSave query values with helper.
readarr/downloadclient.go Replace inline forceSave query values with helper.
radarr/indexer.go Replace inline forceSave query values with helper.
radarr/importlist.go Replace inline forceSave query values with helper.
radarr/downloadclient.go Replace inline forceSave query values with helper.
prowlarr/indexerproxy.go Replace inline forceSave query values with helper.
prowlarr/indexer.go Replace inline forceSave query values with helper.
prowlarr/downloadclient.go Replace inline forceSave query values with helper.
prowlarr/app.go Replace inline forceSave query values with helper.
lidarr/indexer.go Replace inline forceSave query values with helper.
lidarr/importlist.go Replace inline forceSave query values with helper.
lidarr/downloadclient.go Replace inline forceSave query values with helper.
helpers.go Add ForceSave(bool) url.Values helper.
go.mod Update required module versions (notably golang.org/x/net) and tidy test deps.
go.sum Updated sums after dependency refresh/tidy.
.golangci.yml Disable additional linters / adjust test-file exclusions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread starrcmd/parser.go
@davidnewhall
davidnewhall merged commit 303c1ab into main Aug 20, 2026
10 of 11 checks passed
@davidnewhall
davidnewhall deleted the dn2_lint2 branch August 20, 2026 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants