Lint fixes, helper function - #203
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies linter-driven cleanups, introduces a shared helper for the common forceSave query parameter, and refreshes Go module dependencies/configuration.
Changes:
- Added
starr.ForceSave(bool)helper and replaced repeatedurl.Values{"forceSave": ...}constructions across *arr clients. - Updated
.golangci.ymldisables/exclusions in response to new linter findings. - Ran dependency updates/tidy (
go.mod/go.sum), including bumpinggolang.org/x/net.
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| starrcmd/parser.go | Lint-driven change in reflection kind check. |
| sonarr/metadata.go | Use starr.ForceSave for forceSave query construction. |
| sonarr/indexer.go | Replace inline forceSave query values with helper. |
| sonarr/importlist.go | Replace inline forceSave query values with helper. |
| sonarr/downloadclient.go | Replace inline forceSave query values with helper. |
| readarr/indexer.go | Replace inline forceSave query values with helper. |
| readarr/importlist.go | Replace inline forceSave query values with helper. |
| readarr/downloadclient.go | Replace inline forceSave query values with helper. |
| radarr/indexer.go | Replace inline forceSave query values with helper. |
| radarr/importlist.go | Replace inline forceSave query values with helper. |
| radarr/downloadclient.go | Replace inline forceSave query values with helper. |
| prowlarr/indexerproxy.go | Replace inline forceSave query values with helper. |
| prowlarr/indexer.go | Replace inline forceSave query values with helper. |
| prowlarr/downloadclient.go | Replace inline forceSave query values with helper. |
| prowlarr/app.go | Replace inline forceSave query values with helper. |
| lidarr/indexer.go | Replace inline forceSave query values with helper. |
| lidarr/importlist.go | Replace inline forceSave query values with helper. |
| lidarr/downloadclient.go | Replace inline forceSave query values with helper. |
| helpers.go | Add ForceSave(bool) url.Values helper. |
| go.mod | Update required module versions (notably golang.org/x/net) and tidy test deps. |
| go.sum | Updated sums after dependency refresh/tidy. |
| .golangci.yml | Disable additional linters / adjust test-file exclusions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linter updated and brought some new findings. Some suppressed, some fixed. Added a helper method to deal with duplication of "force save" all over the place.
Also ran
go get -u ./... ; go mod tidy