Fixing minor#65
Open
willy182 wants to merge 2 commits into
Open
Conversation
Collaborator
willy182
commented
Dec 7, 2025
willy182
commented
- update path module
- copy file query_param to candishared folder
willy182
requested review from
dimassantoso,
fathiraz and
harissudrajat
and removed request for
a team
fathiraz
approved these changes
Dec 9, 2025
dimassantoso
approved these changes
Dec 9, 2025
harissudrajat
approved these changes
Dec 10, 2025
| @@ -1,3 +1,5 @@ | |||
| // DEPRECATED: move to candishared | |||
Contributor
There was a problem hiding this comment.
Maybe you can add a DEPRECATED comment to each function that has been moved to the candishared module, so users are aware that those functions are deprecated.
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.